Skip to content

Sheffield | 26-ITP-JAN | Grant Riches | Sprint 2 | Form Controls #1110

Open
grantriches-byte wants to merge 15 commits intoCodeYourFuture:mainfrom
grantriches-byte:form-control
Open

Sheffield | 26-ITP-JAN | Grant Riches | Sprint 2 | Form Controls #1110
grantriches-byte wants to merge 15 commits intoCodeYourFuture:mainfrom
grantriches-byte:form-control

Conversation

@grantriches-byte
Copy link

@grantriches-byte grantriches-byte commented Jan 31, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Form sheets completed with controls
  • Achieved 100 score in Lighthouse

@github-actions

This comment has been minimized.

Sign in to view
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@netlify
Copy link

netlify bot commented Jan 31, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 178cb6f
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69886d9a5649f80008359e06
😎 Deploy Preview https://deploy-preview-1110--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 7, 2026
SlideGauge
SlideGauge reviewed Feb 7, 2026
View reviewed changes
Form-Controls/index.html
<main>
<h1>Order Your T-Shirt</h1>

<form>
Copy link

@SlideGauge SlideGauge Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you doublecheck the end tag of the form?

Copy link
Author

@grantriches-byte grantriches-byte Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the html closing tag.

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 7, 2026
@grantriches-byte grantriches-byte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SlideGauge SlideGauge SlideGauge left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grantriches-byte @SlideGauge